fix(query): fixed fn for "SQL Server Database With Unrecommended Retention Days" query#7670
Merged
cx-artur-ribeiro merged 6 commits intomasterfrom Aug 22, 2025
Merged
fix(query): fixed fn for "SQL Server Database With Unrecommended Retention Days" query#7670cx-artur-ribeiro merged 6 commits intomasterfrom
cx-artur-ribeiro merged 6 commits intomasterfrom
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Closes #
Reason for Proposed Changes
Proposed Changes
Microsoft.Sql/servers/, I added to the variable calledtypesthe name of its auditingSettings child resource(Microsoft.Sql/servers/auditingSettings).dbTypeswhich has the names of the resource types that the "father" resources have("Microsoft.Sql/servers/databases", "Microsoft.Sql/servers").retentionDaysfield is not defined and the other one for the cases when it's defined but with a value under 90, which should also return a vulnerable result.dbTypes(represents the father resources), it is extracted is child resources using the helper functionget_childrenwhich is a modification from the functionget_childrenfrom the KICS arm_lib, that serves the purpose of this query.not common_lib.valid_key(parent, "resources")and for the child resources it does not have the fielddependsOn(it's a field that appears on JSON format samples). The third case is for the samples in JSON format that has the resources defined sequentially.retentionDaysis not defined.retentionDaysis defined to a value under 90.Microsoft.Sql/serversresource type.I submit this contribution under the Apache-2.0 license.